Skip to content

Make ProgressBar:set_tab_with take &self #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djc merged 1 commit into from
Jan 16, 2025
Merged

Make ProgressBar:set_tab_with take &self #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/progress_bar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ impl ProgressBar {
}

/// Sets the tab width (default: 8). All tabs will be expanded to this many spaces.
pub fn set_tab_width(&mut self, tab_width: usize) {
pub fn set_tab_width(&self, tab_width: usize) {
let mut state = self.state();
state.set_tab_width(tab_width);
state.draw(true, Instant::now()).unwrap();
Expand Down
4 changes: 2 additions & 2 deletions tests/render.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,7 @@ fn basic_tab_expansion() {
let mp =
MultiProgress::with_draw_target(ProgressDrawTarget::term_like(Box::new(in_mem.clone())));

let mut spinner = mp.add(ProgressBar::new_spinner().with_message("Test\t:)"));
let spinner = mp.add(ProgressBar::new_spinner().with_message("Test\t:)"));
spinner.tick();

// 8 is the default number of spaces
Expand All @@ -753,7 +753,7 @@ fn tab_expansion_in_template() {
let mp =
MultiProgress::with_draw_target(ProgressDrawTarget::term_like(Box::new(in_mem.clone())));

let mut spinner = mp.add(
let spinner = mp.add(
ProgressBar::new_spinner()
.with_message("Test\t:)")
.with_prefix("Pre\tfix!")
Expand Down
Loading