Fix wide_msg truncation with a colored message#740
Merged
djc merged 1 commit intoconsole-rs:mainfrom Oct 26, 2025
Merged
Conversation
glehmann
force-pushed
the
gln/widebar-truncation-fix-pvlv
branch
from
5db56c8 to
01454d2
Compare
djc
reviewed
Oct 23, 2025
glehmann
force-pushed
the
gln/widebar-truncation-fix-pvlv
branch
3 times, most recently
from
2a046cb to
747671c
Compare
Contributor
Author
|
I think there would be a bug with unicode combining diacritical marks. I'm checking |
glehmann
force-pushed
the
gln/widebar-truncation-fix-pvlv
branch
from
747671c to
b0406af
Compare
Contributor
Author
Fixed and tested :) |
glehmann
changed the title
ANSI control sequences were not taken into account.
glehmann
force-pushed
the
gln/widebar-truncation-fix-pvlv
branch
from
b0406af to
50e2651
Compare
djc
approved these changes
Oct 26, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ANSI control sequences were not taken into account.