Merged
Conversation
When initializing progress bar with style that exposes template variable
`{duration}`, the duration is set to 0 after progress bar finishes.
This is is unexpected and makes progress bar styles other than
'ProgressFinish::AndClear' display wrong duration.
This will add Duration parameter to `crate::state::State::Done*`
variants and uses it to display duration if curret state of the progress
bar is one of the Done states.
Fixes console-rs#557
djc
reviewed
Nov 18, 2025
Change 1: More compact (and readable) pattern match for ProgressState.duration() method. Change 2: Refactor unidiomatic custom test specific constructor to
djc
reviewed
Nov 18, 2025
djc
approved these changes
Nov 18, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initializing progress bar with style that exposes template variable
{duration}, the duration is set to 0 after progress bar finishes.This is is unexpected and makes progress bar styles other than 'ProgressFinish::AndClear' display wrong duration.
This will add Duration parameter to
crate::state::State::Done*variants and uses it to display duration if curret state of the progress bar is one of the Done states.Fixes #557