Skip to content

Seeking heuristic tweaks#751

Merged
chris-laplante merged 6 commits intomainfrom
seek-max-tweaks
Nov 18, 2025
Merged

Seeking heuristic tweaks#751
chris-laplante merged 6 commits intomainfrom
seek-max-tweaks

Conversation

@djc
Copy link
Member

@djc djc commented Nov 18, 2025

@djc djc requested a review from chris-laplante November 18, 2025 13:56
Copy link
Collaborator

@chris-laplante chris-laplante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chris-laplante chris-laplante merged commit 95088ff into main Nov 18, 2025
11 checks passed
@djugei
Copy link
Contributor

djugei commented Nov 20, 2025

commented inline here: 41050b0#commitcomment-170873090

i think the variable should be called dejitter not something with max in its name.

@djc
Copy link
Member Author

djc commented Nov 20, 2025

Quoting here because comments on commits tend not to be very accessible:

i feel like dejitter is the more appropriate name, i had it named something with max in its name during devlopment, but that specifies the implementation, not the function.

holding the maximum is good for header-formats, but maybe there is footer formats that want to hold the minimum. or we later on discover that calculating a median is better and covers all use cases etc.

I think this name better describes the current approach -- we can generalize later if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants