This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Select ipv4 first if there is one.#803
Merged
Random-Liu merged 1 commit intocontainerd:masterfrom Jun 5, 2018
Merged
Conversation
Signed-off-by: Lantao Liu <lantaol@google.com>
mikebrow
approved these changes
Jun 5, 2018
| return portMappings | ||
| } | ||
|
|
||
| // selectPodIP select an ip from the ip list. It prefers ipv4 more than ipv6. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #783.
Select ipv4 address if there is one.
The expected behavior is not clearly defined in Kubernetes, but this is the implementation for all existing kubernetes network plugins. https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/dockershim/network/plugins.go#L251
Signed-off-by: Lantao Liu lantaol@google.com