This repository was archived by the owner on Mar 9, 2022. It is now read-only.
sandbox: separate host accessing workload and privileged#866
Merged
Conversation
VM isolated runtimes can support privileged workloads. In this scenario, access to the guest VM is provided instead of the host. Based on this, allow untrusted runtimes to run privileged workloads. If the workload is specifically asking for node PID/IPC/network, etc., then continue to require the trusted runtime. This commit repurposes the hostPrivilegedSandbox utility function to only check for node namespace checking. Fixes: containerd#855 Signed-off-by: Eric Ernst <eric.ernst@intel.com>
Member
|
just have to pick up the ci fix first then merge.. fun.. |
mikebrow
approved these changes
Jul 26, 2018
Member
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
/LGTM
with ci fix to clear tests
Member
Author
|
/test pull-cri-containerd-verify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherrypick #857 to catch the containerd 1.2 release train, or else we need to wait till end of September.