'Access-Control-Allow-Private-Network = true' header for http response#318
Merged
corydolphin merged 1 commit intocorydolphin:masterfrom Apr 11, 2023
Merged
'Access-Control-Allow-Private-Network = true' header for http response#318corydolphin merged 1 commit intocorydolphin:masterfrom
corydolphin merged 1 commit intocorydolphin:masterfrom
Conversation
…oogle chrome specification
Author
|
@corydolphin I just want you to know that I'm submitting this pull request about new preflight header google chrome is implementing, it would be great if you could release a new version of the library including it so we can use it from public python package index. Thanks in advance. |
|
I'm also facing this issue, this PR fixes it for me. @corydolphin is there any plan on merging? |
|
Any plans on releasing a new version with this soon? |
corydolphin
approved these changes
Apr 11, 2023
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Sep 6, 2023
## 4.0.0 * Remove support for Python versions older than 3.8 by @WAKayser in corydolphin/flask-cors#330 * Add GHA tooling by @corydolphin in corydolphin/flask-cors#331 ## 3.1.01 * Include examples to specify that schema and port must be included in … by @YPCrumble in corydolphin/flask-cors#294 * two small changes to the documentation, based on issue #290 by @bbbart in corydolphin/flask-cors#291 * Fix typo by @sunarch in corydolphin/flask-cors#304 * FIX: typo in CSRF by @sattamjh in corydolphin/flask-cors#315 * Test against recent Python versions by @pylipp in corydolphin/flask-cors#314 * Correct spelling mistakes by @EdwardBetts in corydolphin/flask-cors#311 * 'Access-Control-Allow-Private-Network = true' header for http response by @chelo-kjml in corydolphin/flask-cors#318 * docs: Fix a few typos by @timgates42 in corydolphin/flask-cors#323 * [Docs] Fix typo in configuration documentation by @sachit-shroff in corydolphin/flask-cors#316
This was referenced Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google chrome browser (and I guess others too) are deprecating direct access to private network endpoints from public websites as part of the Private Network Access (PNA) specification.
Complete information here: https://developer.chrome.com/blog/private-network-access-preflight/
Please merge this change in order to add that header to responses. For now it is working on an ab test level, but is supposed to be released in a couple of google chrome versions.