Explicitly document proper regex requirements for origins#400
Open
valerianb wants to merge 1 commit intocorydolphin:mainfrom
Open
Explicitly document proper regex requirements for origins#400valerianb wants to merge 1 commit intocorydolphin:mainfrom
valerianb wants to merge 1 commit intocorydolphin:mainfrom
Conversation
Author
|
Hey @corydolphin do you have any feedback about this PR ? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike https://pypi.org/project/django-cors-headers/ which documents and gives proper examples of valid regexes for origins, this project does not give any example leaving it to the user to know how to write good regexes.
The regexes used in the unit tests actually allow to circumvent the allowed domains.
This PR aims to improve the documentation and fix the tests.