feat: distinguish values from labels, add per-sensor text labels#121
Open
CarsonBurke wants to merge 2 commits intocosmic-utils:mainfrom
Open
feat: distinguish values from labels, add per-sensor text labels#121CarsonBurke wants to merge 2 commits intocosmic-utils:mainfrom
CarsonBurke wants to merge 2 commits intocosmic-utils:mainfrom
Conversation
Rename existing "label" concept (numeric readouts like "45%") to "value" throughout config, messages, handlers, and UI. Introduce a new "label" concept for descriptive text (e.g. "CPU", "Mem", "Temp") with per-sensor label_visible toggle and panel rendering.
Contributor
Author
Collaborator
|
Thank you! I just noticed that the label only functions as expected when network up/down is combined, when not combined there's toggles for both but only the download ones does anything. Perhaps toggles for icon and label should be move up above download, where the bandwidth in bytes setting is. 
|
Collaborator
|
Same for Disks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames existing "label" (numeric readouts) to "value" and introduces a new per-sensor "label" concept for descriptive text like "CPU", "Mem", "Temp" with per-item toggle and panel rendering, addressing #119 and building on per-sensor icon visibility (#116).