add option to remove top panel#1
Merged
edfloreshz merged 1 commit intocosmic-utils:mainfrom May 4, 2024
YkdWaWEzVmphR1Z1:show-panel
Merged
add option to remove top panel#1edfloreshz merged 1 commit intocosmic-utils:mainfrom YkdWaWEzVmphR1Z1:show-panel
edfloreshz merged 1 commit intocosmic-utils:mainfrom
YkdWaWEzVmphR1Z1:show-panel
Conversation
Member
|
Isn't this the same as disabling the top panel in COSMIC Settings? |
Contributor
|
I believe only the Dock can be disabled. There isn't a toggle for that in Panel settings. |
Member
|
True! I'll review this a bit later then. |
edfloreshz
reviewed
May 4, 2024
src/pages/panel.rs
Outdated
| widget::scrollable( | ||
| widget::settings::view_section("Panel") | ||
| .add( | ||
| widget::settings::item::builder("Show panel") |
Member
There was a problem hiding this comment.
Could you add a key for this in i18n/en/cosmic_tweaks.ftl?
edfloreshz
requested changes
May 4, 2024
Member
edfloreshz
left a comment
edfloreshz
left a comment
There was a problem hiding this comment.
Please resolve the comment and we can merge 👍🏼
Member
|
Thanks! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.