Merged
Conversation
this commit fixes concurrency issues with cosmic-panel when loading a panel template Signed-off-by: Ryan Brue <ryanbrue.dev@gmail.com>
ryanabx
approved these changes
Oct 31, 2024
Contributor
ryanabx
left a comment
ryanabx
left a comment
There was a problem hiding this comment.
Let's ship it! The UI looks great, and from my testing it works!
Member
Author
|
Why are you not in cosmic-utils? I'll send you an invite |
Contributor
|
Is CI broken? If that's expected I can go ahead and merge |
Member
Author
|
Yeah it's broken, I'll send a fix after merging. |
Member
Author
|
Thanks @ryanabx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layouts are here! 🎉 will you create custom panel arrangements and save them for later use.
Tweaks comes with 4 standard layouts: COSMIC, macOS, Windows, and Ubuntu. More layouts are on the way.
Thanks to @ryanabx for implementing the logic behind this.