Update cosmic_ext_tweaks.ftl (add TM) #83
Merged
Annotations
10 warnings
|
src/main.rs#L411
warning: the following explicit lifetimes could be elided: 'a
--> src/pages/color_schemes/mod.rs:411:25
|
411 | fn available_themes<'a>(&'a self) -> Element<'a, Message> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
411 - fn available_themes<'a>(&'a self) -> Element<'a, Message> {
411 + fn available_themes(&self) -> Element<'_, Message> {
|
|
|
src/main.rs#L371
warning: the following explicit lifetimes could be elided: 'a
--> src/pages/color_schemes/mod.rs:371:25
|
371 | fn installed_themes<'a>(&'a self) -> Element<'a, Message> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
371 - fn installed_themes<'a>(&'a self) -> Element<'a, Message> {
371 + fn installed_themes(&self) -> Element<'_, Message> {
|
|
|
src/main.rs#L350
warning: the following explicit lifetimes could be elided: 'a
--> src/pages/color_schemes/mod.rs:350:17
|
350 | pub fn view<'a>(&'a self) -> Element<'a, Message> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
350 - pub fn view<'a>(&'a self) -> Element<'a, Message> {
350 + pub fn view(&self) -> Element<'_, Message> {
|
|
|
src/main.rs#L96
warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
--> src/pages/color_schemes/preview.rs:96:21
|
96 | / color_scheme
97 | | .author
98 | | .as_ref()
99 | | .and_then(|author| Some(widget::text::caption(author.clone()))),
| |_______________________________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
= note: `#[warn(clippy::bind_instead_of_map)]` on by default
help: try
|
96 ~ color_scheme
97 + .author
98 ~ .as_ref().map(|author| widget::text::caption(author.clone())),
|
|
|
src/main.rs#L12
warning: methods called `new` usually return `Self`
--> src/core/key_bindings.rs:12:5
|
12 | / pub fn new() -> HashMap<KeyBind, TweaksAction> {
13 | | let mut key_binds = HashMap::new();
14 | |
15 | | macro_rules! bind {
... |
30 | | key_binds
31 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
= note: `#[warn(clippy::new_ret_no_self)]` on by default
|
|
src/main.rs#L12
warning: manual saturating arithmetic
--> src/core/grid.rs:12:26
|
12 | let item_width = width
| __________________________^
13 | | .checked_sub(cols_m1 * column_spacing as usize)
14 | | .unwrap_or(0)
| |_________________________^ help: consider using `saturating_sub`: `width.saturating_sub(cols_m1 * column_spacing as usize)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic
|
|
src/main.rs#L9
warning: manual saturating arithmetic
--> src/core/grid.rs:9:24
|
9 | let width_m1 = width.checked_sub(min_width).unwrap_or(0);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `saturating_sub`: `width.saturating_sub(min_width)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic
= note: `#[warn(clippy::manual_saturating_arithmetic)]` on by default
|
|
src/main.rs#L214
warning: this `match` expression can be replaced with `?`
--> src/app/cosmic.rs:214:27
|
214 | let dialog_page = match self.cosmic.dialog_pages.front() {
| ___________________________^
215 | | Some(some) => some,
216 | | None => return None,
217 | | };
| |_________^ help: try instead: `self.cosmic.dialog_pages.front()?`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
= note: `#[warn(clippy::question_mark)]` on by default
|
|
Resource not accessible by integration - https://docs.github.com/rest/checks/runs#create-a-check-run
|
|
|
The logs for this run have expired and are no longer available.
Loading