Add custom panel sizes #89
Merged
Annotations
10 warnings
|
src/main.rs#L10
warning: large size difference between variants
--> src/app/message.rs:10:1
|
10 | / pub enum Message {
11 | | Dock(pages::dock::Message),
12 | | Panel(pages::panel::Message),
13 | | Layouts(pages::layouts::Message),
| | -------------------------------- the second-largest variant contains at least 176 bytes
14 | | Shortcuts(pages::shortcuts::Message),
15 | | Snapshots(pages::snapshots::Message),
| | ------------------------------------ the largest variant contains at least 1096 bytes
... |
30 | | Open(String),
31 | | }
| |_^ the entire enum is at least 1096 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
15 - Snapshots(pages::snapshots::Message),
15 + Snapshots(Box<pages::snapshots::Message>),
|
|
|
src/main.rs#L110
warning: manual implementation of `Option::map`
--> src/app/dialog.rs:110:49
|
110 | ... .push_maybe(if let Some(error) = error {
| ___________________________________^
111 | | ... Some(
112 | | ... widget::text::caption(error.to_string())
113 | | ... .class(cosmic::style::Text::Accent),
... |
116 | | ... None
117 | | ... })
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
= note: `#[warn(clippy::manual_map)]` on by default
help: try
|
110 ~ .push_maybe(error.as_ref().map(|error| widget::text::caption(error.to_string())
111 ~ .class(cosmic::style::Text::Accent)))
|
|
|
src/main.rs#L93
warning: using `clone` on type `LayoutPreview` which implements the `Copy` trait
--> src/app/dialog.rs:93:37
|
93 | ... preview.clone(),
| ^^^^^^^^^^^^^^^ help: try dereferencing it: `*preview`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
src/main.rs#L78
warning: using `clone` on type `LayoutPreview` which implements the `Copy` trait
--> src/app/dialog.rs:78:29
|
78 | ... preview.clone(),
| ^^^^^^^^^^^^^^^ help: try dereferencing it: `*preview`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
src/main.rs#L20
warning: this `match` expression can be replaced with `?`
--> src/app/dialog.rs:20:27
|
20 | let dialog_page = match app.cosmic.dialog_pages.front() {
| ___________________________^
21 | | Some(some) => some,
22 | | None => return None,
23 | | };
| |_________^ help: try instead: `app.cosmic.dialog_pages.front()?`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
= note: `#[warn(clippy::question_mark)]` on by default
|
|
src/main.rs#L12
warning: methods called `new` usually return `Self`
--> src/app/core/key_bindings.rs:12:5
|
12 | / pub fn new() -> HashMap<KeyBind, TweaksAction> {
13 | | let mut key_binds = HashMap::new();
14 | |
15 | | macro_rules! bind {
... |
30 | | key_binds
31 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
= note: `#[warn(clippy::new_ret_no_self)]` on by default
|
|
src/main.rs#L12
warning: manual saturating arithmetic
--> src/app/core/grid.rs:12:26
|
12 | let item_width = width
| __________________________^
13 | | .checked_sub(cols_m1 * column_spacing as usize)
14 | | .unwrap_or(0)
| |_________________________^ help: consider using `saturating_sub`: `width.saturating_sub(cols_m1 * column_spacing as usize)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic
|
|
src/main.rs#L9
warning: manual saturating arithmetic
--> src/app/core/grid.rs:9:24
|
9 | let width_m1 = width.checked_sub(min_width).unwrap_or(0);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `saturating_sub`: `width.saturating_sub(min_width)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic
= note: `#[warn(clippy::manual_saturating_arithmetic)]` on by default
|
|
Resource not accessible by integration - https://docs.github.com/rest/checks/runs#create-a-check-run
|
|
|
The logs for this run have expired and are no longer available.
Loading