When collecting coverage data be sure to open the hitfile with read access.#1214
Merged
MarcoRossignoli merged 1 commit intocoverlet-coverage:masterfrom Sep 9, 2021
Merged
Conversation
Also, failure to remove the hitfile is not fatal.
|
|
Collaborator
|
Hi @JamesWTruher sorry for the very late answer, is this issue blocking your usage? |
MarcoRossignoli
approved these changes
Sep 9, 2021
Collaborator
MarcoRossignoli
left a comment
MarcoRossignoli
left a comment
There was a problem hiding this comment.
LGTM it's a tmp file with guid appended. I don't see great issue if files will remain there, there are other good way to free up tmp folders if became big and also maybe is used on CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this warrants an issue, please let me know and I'll open one.
We're starting to use coverlet in the PowerShell project to gather coverage data, but our usage may be outside the norm. We collect coverage via execution of PowerShell script which may be started via
sudo- so the hit file may have been created by an elevated user. In this environment, opening the hitfile with write privilege fails. Also, failure to remove the hitfile should not necessarily be fatal (although I have added a warning if the removal fails).I should have mentioned that I have tested this change and enables us to collect coverage date for PowerShell.