Conversation
CaseyCarter
suggested changes
Mar 4, 2019
Contributor
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
Thanks for preparing this PR!
Member
Author
|
@CaseyCarter, thanks for the review! |
Contributor
|
@CaseyCarter, ok to assign this review to you? Please approve when you're happy with it. Thanks! |
JohelEGP
suggested changes
Mar 6, 2019
JohelEGP
reviewed
Mar 6, 2019
CaseyCarter
suggested changes
Mar 7, 2019
Contributor
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
Looks good, modulo @JohelEGP's comments and the ingress paper's failure to add ref_view to <ranges>.
burblebee
requested changes
Mar 8, 2019
Contributor
burblebee
left a comment
burblebee
left a comment
There was a problem hiding this comment.
Need to resolve issue with ref_view (see comments).
CaseyCarter
approved these changes
Mar 8, 2019
burblebee
reviewed
Mar 10, 2019
burblebee
approved these changes
Mar 10, 2019
Renamed some suggested stable labels for new sections.
zygoloid
force-pushed
the
motions-2019-02-lwg-16
branch
from
c8b94a2 to
0b06fcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed some suggested stable labels for new sections.
Fixes #2707.