Dependency updates, and one small features#125
Merged
cricketthomas merged 2 commits intomasterfrom Jun 25, 2025
Merged
Conversation
*Changed dialog title in `KeyVaultTreeList.axaml.cs` from "Open Key Vault By URI" to "Open Key Vault".
…Explorer.csproj` add new menu item for copying the portal URL
cricketthomas
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependency package versions and adjusts UI elements to improve user interaction. Key changes include:
- Changing the dialog title in KeyVaultTreeList.axaml.cs from "Open Key Vault By URI" to "Open Key Vault".
- Adding a new "Copy Portal URL" menu item in KeyVaultTreeList.axaml and implementing the corresponding RelayCommand in KeyVaultTreeListViewModel.
- Upgrading various package versions across project files to the latest supported releases.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| KeyVaultExplorer/Views/CustomControls/KeyVaultTreeList.axaml.cs | Updated dialog title for clarity. |
| KeyVaultExplorer/Views/CustomControls/KeyVaultTreeList.axaml | Added new menu item for copying the portal URL. |
| KeyVaultExplorer/ViewModels/KeyVaultTreeListViewModel.cs | Introduced ClipboardService dependency and implemented the CopyPortalURL command. |
| KeyVaultExplorer/KeyVaultExplorer.csproj | Updated package references to newer versions. |
| Desktop/Desktop.csproj | Updated Avalonia.Desktop and caching memory package versions. |
Comments suppressed due to low confidence (1)
KeyVaultExplorer/Views/CustomControls/KeyVaultTreeList.axaml:47
- [nitpick] Verify that the CopyPortalURLCommand binding correctly connects with its implementation in the view model and that the 'Copy' icon source is available in the UI assets.
Command="{Binding CopyPortalURLCommand}"
| } | ||
|
|
||
| [RelayCommand] | ||
| private async Task CopyPortalURL(KeyVaultResource model) |
There was a problem hiding this comment.
Consider adding error handling around the _clipboardService.SetTextAsync call within the CopyPortalURL command to provide user feedback if the copy operation fails.
GSerjo
approved these changes
Jun 25, 2025
Collaborator
|
This's awesome 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KeyVaultTreeList.axaml.csfrom "Open Key Vault By URI" to "Open Key Vault".