Skip to content

Update kubernetes deps#630

Merged
phisco merged 2 commits intomasterfrom
renovate/kubernetes-deps
Feb 1, 2024
Merged

Update kubernetes deps#630
phisco merged 2 commits intomasterfrom
renovate/kubernetes-deps

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Dec 13, 2023 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
k8s.io/api v0.28.4 -> v0.29.1 age adoption passing confidence
k8s.io/apiextensions-apiserver v0.28.4 -> v0.29.1 age adoption passing confidence
k8s.io/apimachinery v0.28.4 -> v0.29.1 age adoption passing confidence
k8s.io/client-go v0.28.4 -> v0.29.1 age adoption passing confidence
sigs.k8s.io/controller-runtime v0.16.3 -> v0.17.0 age adoption passing confidence
sigs.k8s.io/controller-tools v0.13.0 -> v0.14.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

kubernetes/api (k8s.io/api)

v0.29.1

Compare Source

v0.29.0

Compare Source

v0.28.6

Compare Source

v0.28.5

Compare Source

kubernetes/apiextensions-apiserver (k8s.io/apiextensions-apiserver)

v0.29.1

Compare Source

v0.29.0

Compare Source

v0.28.6

Compare Source

v0.28.5

Compare Source

kubernetes/apimachinery (k8s.io/apimachinery)

v0.29.1

Compare Source

v0.29.0

Compare Source

v0.28.6

Compare Source

v0.28.5

Compare Source

kubernetes/client-go (k8s.io/client-go)

v0.29.1

Compare Source

v0.29.0

Compare Source

v0.28.6

Compare Source

v0.28.5

Compare Source

kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)

v0.17.0

Compare Source

⚠️ Breaking Changes

  • Fake client: Only set TypeMeta for unstructured (#​2633)
  • Update k8s.io/* deps to 1.29 (#​2457 #​2500 #​2553 #​2588 #​2612 #​2615 #​2621)
  • Remove apiutil.NewDiscoveryRESTMapper, use DynamicRESTMapper by default for cache (#​2611)
  • RESTMapper: don't treat non-existing GroupVersions as errors (#​2571)
  • Webhooks: Deprecate admission.Validator and admission.Defaulter (#​2639)
  • Webhooks: Limit size of AdmissionRequests to 7MB and size of TokenReviews to 1MB (#​2598)

✨ New Features

  • Cache: Allow defining options that apply to all namespaces without explicit config (#​2528)
  • Cache: Allow to remove informers (#​2285)
  • Cache: Add option to set WatchErrorHandler on informers (#​2494)
  • Client: client.MatchingFields now supports multiple indexes (#​2512)
  • Fake client: Add flowcontrol api v1 (#​2623)
  • Reconciler: Add reconcile.ObjectReconciler (#​2592)

🐛 Bug Fixes

  • Add corev1, coordinationv1 scheme for leader election when LeaderElection manager option is true (#​2461)
  • Cache: Default namespace only for namespaced object (#​2480)
  • Client: Don't truncate large int64s in MergePatch (#​2650)
  • controllerutil: Add RemoveControllerReference and HasControllerReference func (#​2509 #​2595)
  • controllerutil: Add RemoveOwnerReference func (#​2462)
  • Dependencies: Refactor tests to drop hard otel dependency (#​2460)
  • Envtest: CRDs that aren't convertible should unset spec.conversion (#​2525)
  • Fake client: Correctly identify if patch call was made on status (#​2508)
  • Fake client: Do not update anything but status when using subresource client (#​2479)
  • Fake client: Fix returning object after status update (#​2489)
  • Fake client: Fix status subresource getting updated on Update when it is empty (#​2484)
  • Fake client: Handle unstructured status update with fake client (#​2495)
  • Manager: Fix goroutine leak (#​2527)
  • Manager: Use HTTP client from leaderElectionConfig for leader election recorder provider (#​2464)
  • RESTMapper: Return NoResourceMatchError when appropriate for backwards compatibility. (#​2472)
  • Webhook: Handle http.NoBody (#​2605)

🌱 Others

  • Client: Make client.MatchingLabels faster (#​2529)
  • Envtest: Allow to ignore scheme.Convertible check for CRDs (#​2555)
  • Envtest: Improve process cleanup (#​2560)
  • Metrics: Add 100/1000s buckets for Prometheus workqueue histograms (#​2638)
  • Metrics: Avoid dependency on apiserver/options if metrics/filters are used (#​2645)
  • Replace k8s.io/utils/pointer with k8s.io/utils/ptr (#​2488)
  • Webhooks: Cleanup webhook variable assignment (#​2604)

🌱 Dependencies

  • Bump github.com/emicklei/go-restful/v3 from v3.9.0 to 3.11.0 (#​2507)
  • Bump github.com/evanphx/json-patch from 5.6.0+incompatible to 4.12.0+incompatible (#​2501 #​2643)
    • Note: We "downgraded" to v4.12.0+incompatible because it is actually newer than v5.6.0+incompatible and to make sure the code in fake client that is using this dependency behaves exactly the same as the corresponding upstream code. We recommend users to either use github.com/evanphx/json-patch@v4.12.0+incompatible or to upgrade to github.com/evanphx/json-patch/v5@​v5.8.0. More details can be fouhttps://github.com/kubernetes-sigs/controller-runtime/pull/2643#discussion_r1446189655189655.
  • Bump github.com/evanphx/json-patch/v5 from 5.6.0 to 5.8.0 (#​2499 #​2650)
  • Bump github.com/fsnotify/fsnotify from 1.6.0 to 1.7.0 (#​2561)
  • Bump github.com/go-logr/logr from 1.2.4 to 1.4.1 (#​2566 #​2630)
  • Bump github.com/go-logr/zapr from 1.2.4 to 1.3.0 (#​2574)
  • Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 (#​2545)
  • Bump github.com/onsi/ginkgo/v2 from 2.11.0 to 2.14.0 (#​2458 #​2514 #​2534 #​2578 #​2610 #​2651)
  • Bump github.com/onsi/gomega from 1.27.10 to 1.30.0 (#​2521 #​2562 #​2568 #​2579)
  • Bump github.com/prometheus/client_golang from 1.16.0 to 1.18.0 (#​2520 #​2632)
  • Bump github.com/prometheus/client_model from 0.4.1-0.20230718164431-9a2bf3000d16 to 0.5.0 (#​2535)
  • Bump go.uber.org/goleak from 1.2.1 to 1.3.0 (#​2569)
  • Bump go.uber.org/zap from 1.25.0 to 1.26.0 (#​2502)
  • Bump golang.org/x/net to 0.17.0 (#​2540)
  • Bump golang.org/x/sys from 0.11.0 to 0.16.0 (#​2470 #​2533 #​2572 #​2597 #​2642)
  • Bump k8s.io/klog/v2 from 2.100.1 to 2.110.1 (#​2573)
  • Bump sigs.k8s.io/yaml from 1.3.0 to 1.4.0 (#​2567)
  • Bump controller-tools from v0.13.0 to v0.14.0 (#​2649)
  • Bump go-apidiff from v0.5.0 to v0.8.2 (#​2517 #​2655)
  • Upgrade dependencies for hack/tools and tools/ (#​2517)
  • Bump kubernetes-sigs/kubebuilder-release-tools from 0.3.0 to 0.4.3 (#​2532 #​2575 #​2618)
  • Bump golang version in GH actions (#​2609)
  • Bump actions/checkout from 3 to 4 (#​2469)
  • Bump actions/setup-go from 4 to 5 (#​2617)
  • Bump envtest to 1.28.0 (#​2531)

📖 Additionally, there have been 5 contributions to our documentation. (#​2497, #​2498, #​2538, #​2599, #​2602, #​2635 #​2647)

Thanks to all our contributors! 😊

kubernetes-sigs/controller-tools (sigs.k8s.io/controller-tools)

v0.14.0

Compare Source

What's Changed

Dependency bumps

New Contributors

Full Changelog: kubernetes-sigs/controller-tools@v0.13.0...v0.14.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested review from a team as code owners December 13, 2023 20:13
@renovate renovate bot added the automated label Dec 13, 2023
@renovate renovate bot requested review from nullable-eth and phisco December 13, 2023 20:13
@renovate renovate bot force-pushed the renovate/kubernetes-deps branch from 716b8b4 to 028ac9a Compare January 8, 2024 09:44
@renovate renovate bot changed the title Update kubernetes deps to v0.29.0 Update kubernetes deps Jan 11, 2024
@renovate renovate bot force-pushed the renovate/kubernetes-deps branch 3 times, most recently from 3f871ec to d1a773b Compare January 18, 2024 04:26
@renovate renovate bot force-pushed the renovate/kubernetes-deps branch 2 times, most recently from 9f27180 to c3e5a27 Compare January 28, 2024 12:28
@renovate renovate bot force-pushed the renovate/kubernetes-deps branch from c3e5a27 to d05b5c2 Compare January 31, 2024 14:03
@phisco phisco mentioned this pull request Jan 31, 2024
Merged
6 tasks
@phisco phisco self-requested a review January 31, 2024 14:06
@phisco @MisterMX
fix: add RemoveInformer to implement Informers
8886571 
Co-authored-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com>
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
@phisco phisco requested a review from sttts January 31, 2024 15:11
phisco
phisco reviewed Jan 31, 2024
View reviewed changes
pkg/controller/cache.go
return c.fallback.GetInformerForKind(ctx, gvk, opts...)
}

// RemoveInformer removes an informer entry and stops it if it was running.
Copy link
Contributor

@phisco phisco Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sttts mind having a look at this as the original author of the rest of the code?

Copy link
Member

@negz negz Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this new method needed to satisfy an updated interface?

Copy link
Contributor

@phisco phisco Feb 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Informers.

sttts
sttts reviewed Jan 31, 2024
View reviewed changes
pkg/controller/cache.go

c.lock.RLock()
delegate, ok := c.delegates[gvk]
c.lock.RUnlock()
Copy link
Contributor

@sttts sttts Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this remove the delegate from the map?

Copy link
Contributor

@MisterMX MisterMX Jan 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know a way to determine if a delegate has any more informers. Would it hurt to just keep a delegate in any case?

@MisterMX MisterMX mentioned this pull request Jan 31, 2024
Closed
2 tasks
@renovate
Copy link
Contributor Author

renovate bot commented Jan 31, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@phisco phisco merged commit fa4ffff into master Feb 1, 2024
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Merged
@github-actions
Copy link

github-actions bot commented Feb 1, 2024

Successfully created backport PR for release-1.15:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@negz negz negz left review comments

@phisco phisco phisco approved these changes

@MisterMX MisterMX MisterMX left review comments

@nullable-eth nullable-eth Awaiting requested review from nullable-eth nullable-eth was automatically assigned from crossplane/crossplane-reviewers

+1 more reviewer

@sttts sttts sttts left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automated backport release-1.15

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sttts @negz @phisco @MisterMX