Add a nil case to the getValueFromInterface function#666
Merged
phisco merged 3 commits intocrossplane:masterfrom Feb 13, 2024
Merged
Add a nil case to the getValueFromInterface function#666phisco merged 3 commits intocrossplane:masterfrom
getValueFromInterface function#666phisco merged 3 commits intocrossplane:masterfrom
Conversation
sergenyalcin
force-pushed
the
handle-nil-case
branch
from
a739e1e to
896dc1a
Compare
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
sergenyalcin
force-pushed
the
handle-nil-case
branch
from
896dc1a to
5cd11c9
Compare
ulucinar
approved these changes
Feb 6, 2024
Contributor
ulucinar
left a comment
ulucinar
left a comment
There was a problem hiding this comment.
Thanks @sergenyalcin, lgtm.
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
phisco
reviewed
Feb 7, 2024
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
phisco
approved these changes
Feb 13, 2024
1 task
Member
|
any reason why this PR is not with label for backport to v1.15 release ? - looks like we started using 1.16 rc for providers https://github.com/upbound/provider-aws/blob/main/go.mod#L13 after crossplane-contrib/provider-upjet-aws#1159 |
Contributor
Lets backport it. If the providers need it better that they use v1.15.x then the rc for v1.16 |
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds a nil case to the
getValueFromInterfacefunction to handle the case that the value of the segment is nil. This issue was observed while testing the conversion functions in provider-aws.This PR addresses the same issue as here, but for a different function.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested locally for the observed case.