logging: add SetFilteredKlogLogger to show client-go throttling logs#673
Merged
negz merged 1 commit intocrossplane:masterfrom Feb 26, 2024
Merged
logging: add SetFilteredKlogLogger to show client-go throttling logs#673negz merged 1 commit intocrossplane:masterfrom
negz merged 1 commit intocrossplane:masterfrom
Conversation
072e15d to
c8f2cc9
Compare
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
c8f2cc9 to
5f2a278
Compare
Merged
2 tasks
negz
approved these changes
Feb 23, 2024
Comment on lines
+15
to
+17
| // SetFilteredKlogLogger sets log as the logger backend of klog, but filtering | ||
| // aggressively to avoid noise. | ||
| func SetFilteredKlogLogger(log logr.Logger) { |
Member
There was a problem hiding this comment.
Perhaps this should have something WRT "request throttling" in the name, to make it obvious why it's filtering. Unless you think we might include more in future?
Contributor
Author
There was a problem hiding this comment.
Was thinking that maybe we will add more some day, i.e. this is more like the standard klog setup for crossplane components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
It's hard to understand which component is causing slowness. This PR enables client throttling logging, both for server-side and client-side, i.e. these pass:
For example:
This is just in Crossplane. It probably needs a log setup helper in controller-runtime and then vendored into providers.
Of course, this information could also be understood from metrics, but metrics are complicated, hard to discover and need tons of knowledge to understand right.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested in crossplane/crossplane#5419.