Merged
Conversation
6 tasks
negz
commented
May 30, 2024
| token: '${{ steps.get-github-app-token.outputs.token }}' | ||
| mount-docker-socket: true | ||
| docker-user: root | ||
| docker-cmd-file: .github/renovate-entrypoint.sh |
Member
Author
There was a problem hiding this comment.
negz
force-pushed
the
third-rock-from-the-sun
branch
2 times, most recently
from
d3c908a to
8b63379
Compare
Actually install it in the Renovate container, not the runner environment. Also, run make rather than earthly on release branches. Signed-off-by: Nic Cope <nicc@rk0n.org>
negz
force-pushed
the
third-rock-from-the-sun
branch
from
8b63379 to
7305ea7
Compare
phisco
approved these changes
May 30, 2024
Contributor
phisco
left a comment
phisco
left a comment
There was a problem hiding this comment.
let's see 🤞 FYI for tests I usually run it on my fork and merge stuff to main there, it's a bit more tedious with the gha based approach though, you have to set up the app and so on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Actually install it in the Renovate container, not the runner environment.
Also, run make rather than earthly on release branches.
I have:
Runearthly +reviewableto ensure this PR is ready for review.Added or updated unit tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.