feat(managed): Add generic interfaces for external types#761
Merged
phisco merged 1 commit intocrossplane:mainfrom Oct 24, 2024
Merged
feat(managed): Add generic interfaces for external types#761phisco merged 1 commit intocrossplane:mainfrom
phisco merged 1 commit intocrossplane:mainfrom
Conversation
MisterMX
force-pushed
the
feat/typed-external-connector
branch
from
d27f90b to
1cb018a
Compare
Add a wrapper for typed external clients that take over the conversion from resource.Managed to the actual Go struct that is always necessary in every controller. It does not reduce complexity as a whole but allows controllers to save some LoCs and focus on the important things. Keep the previous types as type aliases to avoid any breaking changes. Signed-off-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com>
MisterMX
force-pushed
the
feat/typed-external-connector
branch
from
1cb018a to
7f2eeb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add a wrapper for typed external clients that take over the conversion from resource.Managed to the actual Go struct that is always necessary in every controller. It does not reduce complexity as a whole but allows controllers to save some LoCs and focus on the important things.
Keep the previous types as type aliases to avoid any breaking changes.
I have:
earthly +reviewableto ensure this PR is ready for review.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.