Add filter functions to event recorder#829
Merged
negz merged 1 commit intocrossplane:mainfrom Jul 19, 2025
Merged
Conversation
5 tasks
chlunde
reviewed
May 19, 2025
negz
reviewed
Jun 9, 2025
frigaut-orange
changed the title
frigaut-orange
force-pushed
the
feature-namespace-restricted-option
branch
from
4f2def1 to
c1d8734
Compare
negz
reviewed
Jun 10, 2025
negz
reviewed
Jun 10, 2025
negz
reviewed
Jun 10, 2025
Member
|
Few nits but otherwise this LGTM. Not sure why CI is reluctant to run - closed and reopened the issue to try to get it to start. |
frigaut-orange
force-pushed
the
feature-namespace-restricted-option
branch
from
c1d8734 to
ff6012f
Compare
Signed-off-by: François Rigaut <francois.rigaut@orange.com>
frigaut-orange
force-pushed
the
feature-namespace-restricted-option
branch
from
ff6012f to
61bc9ed
Compare
frigaut-orange
changed the title
negz
approved these changes
Jul 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Added a namespaced APIRecorder to create events only on namespaced resources.
Related issue : crossplane/crossplane#6348
Related design PR : crossplane/crossplane#6419
I have:
earthly +reviewableto ensure this PR is ready for review.Added or updated unit tests. (todo)Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the [cheat sheet].