Skip to content

fix lint issue on deprecated interfaces#840

Merged
negz merged 1 commit intocrossplane:mainfrom
n3wscott:fix-dupe-interface
May 21, 2025
Merged

fix lint issue on deprecated interfaces#840
negz merged 1 commit intocrossplane:mainfrom
n3wscott:fix-dupe-interface

Conversation

@n3wscott
Copy link
Contributor

Description of your changes

Noticed the build started failing after #835 was merged. SORRY!! Here is a fix to ignore the linting error. Not sure why it was not caught in the normal CI?

I have:

  • Read and followed Crossplane's [contribution process].
  • Run earthly +reviewable to ensure this PR is ready for review.
    - [ ] Added or updated unit tests.
    - [ ] Linked a PR or a [docs tracking issue] to [document this change].
    - [ ] Added backport release-x.y labels to auto-backport this PR.

Signed-off-by: Scott Nichols <n3wscott@upbound.io>
@n3wscott n3wscott requested a review from a team as a code owner May 21, 2025 21:09
@n3wscott n3wscott requested a review from jbw976 May 21, 2025 21:09
Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. 🤔

Maybe a race with 8e6ab16, which updated the linter rules? Could be your branch wasn't up-to-date with that?

@negz negz merged commit 15b6a55 into crossplane:main May 21, 2025
10 checks passed
@n3wscott n3wscott deleted the fix-dupe-interface branch May 21, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants