Skip to content

fix(pipeline-inspector): expose step name too#911

Merged
phisco merged 1 commit intocrossplane:mainfrom
phisco:what-is-your-name
Jan 30, 2026
Merged

fix(pipeline-inspector): expose step name too#911
phisco merged 1 commit intocrossplane:mainfrom
phisco:what-is-your-name

Conversation

@phisco
Copy link
Contributor

@phisco phisco commented Jan 30, 2026

Description of your changes

Step name could also be useful here, we do have that information where the step metadata is setup, so it's trivial to add.

Given that the interface is new, I think we can ignore the breaking change and shift the numbering for now.

Fixes #

I have:

Need help with this checklist? See the cheat sheet.

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
@phisco phisco requested a review from a team as a code owner January 30, 2026 09:43
@phisco phisco requested a review from adamwg January 30, 2026 09:43
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 30, 2026

📝 Walkthrough

Walkthrough

A new step_name field is added to the StepMeta message in the pipeline inspector protocol buffer definition, with all subsequent field numbers renumbered accordingly to maintain proper field numbering sequences.

Changes

Cohort / File(s) Summary
Protocol Buffer Definition
apis/pipelineinspector/proto/v1alpha1/pipeline_inspector.proto
Added step_name string field to StepMeta message at field number 4; renumbered all existing fields (iteration, function_name, composition_name, composite_resource_uid, composite_resource_name, composite_resource_namespace, composite_resource_api_version, composite_resource_kind, timestamp) by incrementing their field numbers by one.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • negz
  • jbw976
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly describes the main change: exposing the step name in the pipeline inspector proto, and stays well under the 72-character limit.
Description check ✅ Passed The PR description is related to the changeset, explaining the rationale for adding step name exposure and addressing the breaking change to the interface numbering.
Breaking Changes ✅ Passed The custom check targets non-generated .go files, but the breaking change is in a .proto file and its generated .pb.go outputs, which are explicitly excluded from scope.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@apis/pipelineinspector/proto/v1alpha1/pipeline_inspector.proto`:
- Around line 82-111: This change to StepMeta (adding string step_name = 4 and
shifting all subsequent tags) is a wire-format breaking change; ensure the PR
has the 'breaking-change' label applied and update PR description to explicitly
state this is intentional for the new pipeline inspector v1alpha1 and that
v1alpha1 may contain breaking changes without a migration path; reference the
proto message StepMeta and the new field step_name (tag 4) in the PR description
and any release notes so reviewers and downstream consumers are aware.

Copy link
Member

@ezgidemirel ezgidemirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @phisco!

@phisco phisco merged commit b375c81 into crossplane:main Jan 30, 2026
8 of 10 checks passed
Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see that the protobuf-schemas check caught all of these as breaking changes 🙌
https://github.com/crossplane/crossplane-runtime/actions/runs/21511425091/job/61979133723

but yeah, since this is unreleased these breaks are fine 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants