fix(pipeline-inspector): expose step name too#911
Conversation
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
📝 WalkthroughWalkthroughA new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 🧪 Unit Test Generation v2 is now available!We have significantly improved our unit test generation capabilities. To enable: Add this to your reviews:
finishing_touches:
unit_tests:
enabled: trueTry it out by using the Have feedback? Share your thoughts on our Discord thread! Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apis/pipelineinspector/proto/v1alpha1/pipeline_inspector.proto`:
- Around line 82-111: This change to StepMeta (adding string step_name = 4 and
shifting all subsequent tags) is a wire-format breaking change; ensure the PR
has the 'breaking-change' label applied and update PR description to explicitly
state this is intentional for the new pipeline inspector v1alpha1 and that
v1alpha1 may contain breaking changes without a migration path; reference the
proto message StepMeta and the new field step_name (tag 4) in the PR description
and any release notes so reviewers and downstream consumers are aware.
jbw976
left a comment
There was a problem hiding this comment.
Nice to see that the protobuf-schemas check caught all of these as breaking changes 🙌
https://github.com/crossplane/crossplane-runtime/actions/runs/21511425091/job/61979133723
but yeah, since this is unreleased these breaks are fine 😅
Description of your changes
Step name could also be useful here, we do have that information where the step metadata is setup, so it's trivial to add.
Given that the interface is new, I think we can ignore the breaking change and shift the numbering for now.
Fixes #
I have:
earthly +reviewableto ensure this PR is ready for review.Added or updated unit tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.