hax-lib: prop: allow equality on every type#1352
Merged
Conversation
W95Psp
changed the title
W95Psp
force-pushed
the
prop-eq-any-type
branch
from
3ff8e24 to
90107b0
Compare
Contributor
|
Also do this for ne?
…On Tue, Mar 11, 2025, 16:50 Lucas Franceschino ***@***.***> wrote:
@W95Psp <https://github.com/W95Psp> requested review from @cryspen/hax
on: #1352 <#1352> prop: eq on anything
as a code owner.
—
Reply to this email directly, view it on GitHub
<#1352 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFUVS4WLQGUDKTI72T3RRT2T4A5RAVCNFSM6AAAAABYZJBHE6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGY4TCMJZGI3DAOI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Contributor
Author
|
That PR was mainly because I needed it in my minicore models |
Contributor
Author
|
aaah, I thought you mistyped |
maximebuyse
approved these changes
Mar 11, 2025
karthikbhargavan
approved these changes
Mar 11, 2025
Contributor
karthikbhargavan
left a comment
karthikbhargavan
left a comment
There was a problem hiding this comment.
Also did the same for ne
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
Prop::eqto work not only onProps, but on any type: any time should be comparable inProp.