Replace paste by with_builtin_macros.#1394
Conversation
W95Psp
left a comment
There was a problem hiding this comment.
That looks good to me, let's see how maintained with_builtin_macros is, but for now that seems a great solution! :)
And that works without nightly, so that's nice.
|
Are you aware of |
franziskuskiefer
left a comment
There was a problem hiding this comment.
with_builtin_macros doesn't look great 😬
Did you try the macro_metavar_expr_concat? If that works, I think it would be the better option.
Looks like it does what we need, thanks! If we are ok to use something experimental, I'll try it. |
|
Not that I am expert, but in the same thread that talks about |
The suggestion comes from the author of |
franziskuskiefer
left a comment
There was a problem hiding this comment.
If we are ok to use something experimental, I'll try it.
If it works, I think something experimental here within the language feels better than a 3rd party crate. We're on nightly anyway.
Yes it works, let's merge then! |
Fixes #1379.
I looked for a solution without introducing a new dependency.
concat_identsseems like a good candidate but it doesn't work for function names as discussed in rust-lang/rust#29599. So I replacedpastebywith_builtin_macroswhich builts on top ofconcat_identsto provide the functionality we need.