Lean backend [M2] - 3/3 - Resugarings#1591
Merged
clementblaudeau merged 2 commits intomainfrom Sep 1, 2025
Merged
Conversation
This was referenced Aug 1, 2025
46797ea to
d3a7e5d
Compare
W95Psp
approved these changes
Aug 25, 2025
franziskuskiefer
approved these changes
Aug 27, 2025
Member
franziskuskiefer
left a comment
There was a problem hiding this comment.
lgtm, just a few questions and nits
d3a7e5d to
4ae789c
Compare
4ae789c to
b987d37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #1590. It uses the visitors of #1585 to implement resugarings, i.e. passes over the AST that replace certain patterns with special resugared nodes, allowing for a special treatment by the backend.
The Lean extracted code is made much more readable and close to the Rust code. This PR only defines resugaring for some binary arithmetic operations, as a proof of concept.
Example
For instance, the
barrettextracted code goes fromto