proof-libs/lean Add a coercion for unit#1618
Closed
clementblaudeau wants to merge 1 commit intomainfrom
Closed
Conversation
clementblaudeau
changed the title
OfNat for results of nats.
clementblaudeau
changed the title
OfNat for results of nats.proof-libs/lean Add a coercion for unit
clementblaudeau
force-pushed
the
proof-lib/lean-add-unit-coercion
branch
from
94de949 to
1ed4418
Compare
W95Psp
approved these changes
Aug 25, 2025
Contributor
W95Psp
left a comment
W95Psp
left a comment
There was a problem hiding this comment.
Thanks! Looks good, but why is that not polymorphic, and also, this should go away if the backend inserts pure nodes in a smart way, right?
Contributor
Author
|
This issue is a bit orthogonal to the smart insertion of |
Contributor
|
I see, that's a (OCaml) engine bug, right? |
Contributor
Author
|
It might be better to treat this with a proper resugaring phase. I'm moving it to draft in the meantime |
Contributor
Author
|
This came from a confusion in name rendering between the constructor of a struct and its type. Fixed by #1624 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a coercion:
hax_Tuple0can be coerced into aResult hax_Tuple0, used when translating a unit in a return position. It should fix: https://hax-playground.cryspen.com/#lean/latest-main/gist=1494268f2d5e4dafc2a2b78b99df3d3f