Skip to content

feat(rengine): add resugaring for tuples#1662

Merged
W95Psp merged 3 commits intomainfrom
tuples-resugaring-bare
Sep 9, 2025
Merged

feat(rengine): add resugaring for tuples#1662
W95Psp merged 3 commits intomainfrom
tuples-resugaring-bare

Conversation

@W95Psp
Copy link
Copy Markdown
Contributor

@W95Psp W95Psp commented Sep 4, 2025

This PR cherry-picks some commit from @maximebuyse (see PR #1629).
This PR:

  • drop the ExprKind::Tuple and Ty::Tuple nodes from the AST, those were unused (everything is just function or type application)
  • adds a resugaring and corresponding resugaring node for tuples

@W95Psp W95Psp requested a review from a team as a code owner September 4, 2025 13:52
@W95Psp W95Psp requested a review from maximebuyse September 4, 2025 13:52
@W95Psp W95Psp force-pushed the tuples-resugaring-bare branch 2 times, most recently from 30235e0 to 633955e Compare September 4, 2025 13:58
@W95Psp
Copy link
Copy Markdown
Contributor Author

W95Psp commented Sep 4, 2025

@maximebuyse I dropped the Lean changes, thanks :)

Copy link
Copy Markdown
Contributor

@maximebuyse maximebuyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@maximebuyse
Copy link
Copy Markdown
Contributor

Looks good now!

Ah seems like we need to ignore this resugaring case in the lean backend to make CI happy.

@W95Psp W95Psp force-pushed the tuples-resugaring-bare branch 2 times, most recently from c7128f0 to 0aaffa7 Compare September 8, 2025 15:26
@W95Psp W95Psp enabled auto-merge September 8, 2025 15:26
@W95Psp W95Psp added this pull request to the merge queue Sep 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 8, 2025
@W95Psp W95Psp force-pushed the tuples-resugaring-bare branch from 95d115d to e0fe07c Compare September 9, 2025 03:29
@W95Psp W95Psp enabled auto-merge September 9, 2025 03:34
@W95Psp W95Psp added this pull request to the merge queue Sep 9, 2025
Merged via the queue into main with commit 060b8a9 Sep 9, 2025
18 checks passed
@W95Psp W95Psp deleted the tuples-resugaring-bare branch September 9, 2025 04:37
@W95Psp W95Psp restored the tuples-resugaring-bare branch January 15, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants