feat(rengine): output diagnostics in todo!s in printers#1669
Merged
Conversation
W95Psp
force-pushed
the
rengine-printer-diagnostics-todo
branch
2 times, most recently
from
a052753 to
63d58db
Compare
W95Psp
requested review from
a team,
clementblaudeau,
karthikbhargavan and
keks
and removed request for
a team and
karthikbhargavan
keks
approved these changes
Sep 9, 2025
Member
keks
left a comment
keks
left a comment
There was a problem hiding this comment.
I think this looks good, just a nit and an ask for clarificiation.
clementblaudeau
approved these changes
Sep 11, 2025
W95Psp
force-pushed
the
rengine-printer-diagnostics-todo
branch
from
22dba12 to
b658678
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the printer emit diagnostics, catched by
cargo haxand displayed properly:todo!will now emit those diagnosticsemit_diagnosticto emit a contextualized and spanned diagnostic manually