Rust Engine: refactor names, change tuples representation#1693
Rust Engine: refactor names, change tuples representation#1693W95Psp merged 11 commits intorengine-intern-ids-spanfrom
Conversation
jschneider-bensch
left a comment
There was a problem hiding this comment.
This might be really basic, but I need to understand more about the different Id types. I believe none of them are new to the Rust engine, but have been ported from the OCaml engine, right? Is there some documentation in the OCaml engine (or elsewhere) for GlobalId, ConcreteId, DefId, ExplicitDefId and LocalId?
27b7b07 to
4a3ed0b
Compare
|
Thanks for your review! Some are similar to the OCaml engine, but it was mostly redesigned. I added contents in the module doc of |
maximebuyse
left a comment
There was a problem hiding this comment.
I added a small comment, otherwise looks good!
Thanks, that really helps me understand what's happening! |
jschneider-bensch
left a comment
There was a problem hiding this comment.
I think it looks good, thanks for adding more documentation!
ff33f44 to
dbf0aa6
Compare
|
This PR is now reviewed, I'm now waiting for #1689. |
923280a to
8bd565d
Compare
dbf0aa6 to
c9f4ced
Compare
|
I'm merge that branch in its parent branch |
This PR introduces two major changes:
GlobalIdInner::Tuple, which is very simple to pattern match on.How to review
Skip the code regeneration commits