[Lean Backend] Improve support for functionalized loops#1695
Merged
clementblaudeau merged 10 commits intomainfrom Sep 29, 2025
Merged
[Lean Backend] Improve support for functionalized loops#1695clementblaudeau merged 10 commits intomainfrom
clementblaudeau merged 10 commits intomainfrom
Conversation
clementblaudeau
changed the title
clementblaudeau
force-pushed
the
lean-traits
branch
from
937ec0d to
02d8765
Compare
Should be removed once #1646 has been fixed
clementblaudeau
force-pushed
the
lean-loops
branch
from
2eb8a56 to
a347aed
Compare
clementblaudeau
requested review from
W95Psp and
karthikbhargavan
and removed request for
a team and
karthikbhargavan
clementblaudeau
changed the title
W95Psp
approved these changes
Sep 29, 2025
Contributor
W95Psp
left a comment
W95Psp
left a comment
There was a problem hiding this comment.
Looks good to me, I only skemed through the Lean changes.
The OCaml engine type bug was pretty dumb indeed! 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the support for loops in the Lean backend, by:
usize,i32,u64, etc)fold_range_returnBesides, it fixes a small bug in the OCaml engine.
This is temporary, as we plan to not functionalize loops in the Lean backend
[Disclaimer] The proofs of Chacha (in
Lean_chacha20_manual_edits.lean) have been removed. They were broken, and fixed by the refactor in #1696. Fixing them here in a state of the Lean lib that is not going to exist much longer seemed like unnecessary. We can wait for both this and #1696 to be approved and merge them together.