Merged
Conversation
maximebuyse
reviewed
Oct 28, 2025
Contributor
maximebuyse
left a comment
maximebuyse
left a comment
There was a problem hiding this comment.
Great!
About the tests, lean type-checking is not tested on these tests right? So do you manually try that it works?
Contributor
|
Hi, looks good to me! As Maxime mentioned, it would be nice to actually test the Lean type-checking. I did it manually and it worked for me. The name clash between hax's |
This commit adds core-models for: - Options - Results - Default - Fn/FnOnce
clementblaudeau
force-pushed
the
lean-core-models
branch
from
423cf72 to
3c4e631
Compare
Contributor
Author
|
I've rebased on main, and corrected the typo in the core models description. I agree that the name clash for |
maximebuyse
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR leverages the recent work on Core Models to add functions for several modules of Core :
options,result,default,clone,Fn/FnOnce.Overview
proof-libs/lean, models are added. They are lightly adapted (mostly namespacing) from a normalcargo hax into leanof the core-models crate.tests/lean-core-models, add tests for all the functions added in the lean library. The extracted lean is well-typed.rust-engine/backends/lean.rsfix a bug (missing parenthesis)