Skip to content

feat(lean): use macros for int operations#1795

Merged
abentkamp merged 1 commit intomainfrom
lean-int-macros
Dec 18, 2025
Merged

feat(lean): use macros for int operations#1795
abentkamp merged 1 commit intomainfrom
lean-int-macros

Conversation

@abentkamp
Copy link
Copy Markdown
Contributor

@abentkamp abentkamp commented Dec 3, 2025

Fixes #1794
Fixes #1727

@abentkamp abentkamp added this to the Lean proof library v1.0 milestone Dec 3, 2025
@abentkamp abentkamp requested a review from maximebuyse December 3, 2025 09:21
@abentkamp abentkamp requested a review from a team as a code owner December 3, 2025 09:21
@abentkamp abentkamp added proof-lib Issues related the backend-specific definitions (in the proof-lib folder) lean Related to the Lean backend or library labels Dec 3, 2025
@abentkamp abentkamp marked this pull request as draft December 3, 2025 09:23
Copy link
Copy Markdown
Contributor

@maximebuyse maximebuyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lean changes seem fine to me but this seems to break the examples that we run on CI.

@abentkamp abentkamp changed the title refactor(lean): use macros for int operations feat(lean): use macros for int operations Dec 3, 2025
@abentkamp abentkamp force-pushed the lean-int-macros branch 2 times, most recently from db186cf to 61f8f45 Compare December 4, 2025 10:48
@abentkamp abentkamp force-pushed the lean-int-macros branch 3 times, most recently from 27df155 to de2aa17 Compare December 17, 2025 15:34
@abentkamp abentkamp marked this pull request as ready for review December 18, 2025 10:05
Copy link
Copy Markdown
Contributor

@maximebuyse maximebuyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@abentkamp abentkamp added this pull request to the merge queue Dec 18, 2025
Merged via the queue into main with commit 60f874f Dec 18, 2025
17 of 18 checks passed
@abentkamp abentkamp deleted the lean-int-macros branch December 18, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lean Related to the Lean backend or library proof-lib Issues related the backend-specific definitions (in the proof-lib folder)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proof-lib/lean: Have an homogeneous support for all integer types proof-lib/lean Add right-shift with i32 operand for all integer types

2 participants