Conversation
W95Psp
requested review from
abentkamp,
karthikbhargavan and
maximebuyse
and removed request for
karthikbhargavan
abentkamp
approved these changes
Dec 15, 2025
Contributor
abentkamp
left a comment
abentkamp
left a comment
There was a problem hiding this comment.
This seems to work well for generating specs. Please fix the tests and merge so that I can build on top of this more easily.
Contributor
Author
|
Thanks for your reviews, Maxime and Alex! |
W95Psp
force-pushed
the
rengine-attribute-api
branch
from
aa354d3 to
5939581
Compare
My idea was to drain the items that had an UUID. Some items are tagged with an UUID but should not be dropped (e.g. verbatim items). Thus, we have no choice but to clone.
We used to expose modules that defined phases. Instead, this commit exposes the structs on which the trait `Phase` is implemented. Such structs are the only entrypoint to a phase. Nothing else should be visible. This commit also moves doc comment from modules to struct phases.
This is not useful anymore since we now respect the `late_skip` attributes.
…s not support pre/posts
W95Psp
force-pushed
the
rengine-attribute-api
branch
from
7ebbec0 to
46a9f82
Compare
…kend` skip_late items should be dropped only after computing the graph of attributes, which should happen after applying all phases. Thus, dropping skip_late items cannot be a phase.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
W95Psp
force-pushed
the
rengine-attribute-api
branch
2 times, most recently
from
bc9c95c to
ead357c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://www.notion.so/Port-the-attribute-API-over-to-Rust-2788fd40c8e3800a9e71d29c078778b7?source=copy_link
This PR mainly adds the module
attributes, which offers a simple way to construct a graph of items associated via hax attributes (e.g. requires).That graph,
AssociatedItemsGraphcan be queried via e.g. its associated methodfn_like_associated_expressions. Given an item, this method will return its precondition, postcondition and decreases clause, if any.