fix: trait items must be rendered along with the generic params#1813
Merged
fix: trait items must be rendered along with the generic params#1813
Conversation
abentkamp
added
bug
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
fix: trait items must be rendered along with the generic params
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug I just introduced with #1803
The change needed here is analogous to this line of the previous PR: https://github.com/cryspen/hax/pull/1803/files#diff-5874c6378a6193f79ee608b43d18c883b759280096423669907c7408ba487d98R1290
This is necessary because the
trait_itemprinter has been removed entirely:https://github.com/cryspen/hax/pull/1803/files#diff-5874c6378a6193f79ee608b43d18c883b759280096423669907c7408ba487d98L1335
And instead this printer is responsible now: https://github.com/cryspen/hax/pull/1803/files#diff-5874c6378a6193f79ee608b43d18c883b759280096423669907c7408ba487d98R470
[skip changelog]