Skip to content

add rust toolchain file#2

Merged
W95Psp merged 2 commits intomainfrom
franziskus/thir-export-toolchain
Feb 13, 2023
Merged

add rust toolchain file#2
W95Psp merged 2 commits intomainfrom
franziskus/thir-export-toolchain

Conversation

@franziskuskiefer
Copy link
Copy Markdown
Member

Adding a rust toolchain file to make it possible (easier) to build the thir-export.
Unfortunately it looks like the crate itself doesn't work yet. So I'll refrain from digging deeper until we had a chat about what works and what needs to happen to make it work.

@franziskuskiefer franziskuskiefer self-assigned this Feb 3, 2023
@W95Psp
Copy link
Copy Markdown
Contributor

W95Psp commented Feb 6, 2023

Hi Franziskus,

About the Cargo.lock file, we actually need to commit it, Nix uses the lock information so that the thing is always built the same way with the exact same dependencies.

Oh, what is not working? It's not compiling?

@franziskuskiefer
Copy link
Copy Markdown
Member Author

About the Cargo.lock file, we actually need to commit it, Nix uses the lock information so that the thing is always built the same way with the exact same dependencies.

As long as the libraries are only used in the local binary that's fine. Otherwise it's dangerous because you won't know whether it's actually building for other versions of the dependencies.

Oh, what is not working? It's not compiling?

It's compiling but it's only throwing errors.
Can you start by adding documentation here on how you expect this to be used?

@W95Psp W95Psp merged commit dc66b1d into main Feb 13, 2023
@franziskuskiefer franziskuskiefer deleted the franziskus/thir-export-toolchain branch February 13, 2023 08:27
Nadrieril pushed a commit to Nadrieril/hax that referenced this pull request Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants