Skip to content

css nesting support #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 2 commits into from
Dec 21, 2023
Merged

css nesting support #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
368aaab
add failing test for css nesting
jantimon Sep 24, 2023
f1a9971
mark nested local selectors as pure
jantimon Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,11 @@ function localizeNode(rule, mode, localAliasMap) {

break;
}
case "nesting": {
if (node.value === "&") {
context.hasLocals = true;
}
}
}

context.lastWasSpacing = false;
Expand Down
24 changes: 24 additions & 0 deletions test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,6 +844,30 @@ const tests = [
input: ":global(.a:not(:global .b, :global .c)) {}",
error: /A :global is not allowed inside of a :global/,
},
{
name: "consider & statements as pure",
input: ".foo { &:hover { a_value: some-value; } }",
options: { mode: "pure" },
expected: ":local(.foo) { &:hover { a_value: some-value; } }",
},
{
name: "consider selector & statements as pure",
input: ".foo { html &:hover { a_value: some-value; } }",
options: { mode: "pure" },
expected: ":local(.foo) { html &:hover { a_value: some-value; } }",
},
{
name: "consider selector & statements as pure",
input: ".foo { &:global(.bar) { a_value: some-value; } }",
options: { mode: "pure" },
expected: ":local(.foo) { &.bar { a_value: some-value; } }",
},
{
name: "throw on nested & selectors without a local selector",
input: ":global(.foo) { &:hover { a_value: some-value; } }",
options: { mode: "pure" },
error: /is not pure/,
},
/*
Bug in postcss-selector-parser
{
Expand Down