Merged
Conversation
mpkorstanje
reviewed
Oct 9, 2025
Contributor
There was a problem hiding this comment.
The AssertJ fix is good. I'll pull that out separately.
Beyond that I'm not sure how I feel about this change. Checking pre- and post-conditions catches mistakes in understanding early. The checks are also quite inexpensive. I don't think these milligrams of performance gain are worth the potential headache in the future..
java/src/main/java/io/cucumber/gherkin/GherkinDocumentBuilder.java
Outdated
Show resolved
Hide resolved
… the GherkinDocumentBuilder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Minor changes to avoid unnecessary stuff:
⚡️ What's your motivation?
I didn't check the performance as theses are very small changes. But removing unnecessary code is never a bad thing...
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
I couldn't run
make mostlyclean acceptance(these are many errors regarding newlines on Windows).📋 Checklist: