fix #2720 yaml encoding of hex strings

[vikstrous]

See #2720 for details

[mvdan]

Thanks for the fix! I'm not particularly familiar with internal/encoding/yaml myself, but the fix looks simple and clear enough to me.

The test case should go in the encoding/yaml package, for example as part of TestYAMLValues, since internal/encoding/yaml is our fork of go-yaml with all the inherited tests. If/when we eventually update our go-yaml fork or move to an entirely different YAML library, I definitely don't want to lose this regression test :)

[vikstrous2]

I added the test case to encoding/yaml.

[mvdan]

Thank you! Imported to Gerrit as https://review.gerrithub.io/c/cue-lang/cue/+/1173689.

I hope you don't mind that I wrote a longer commit message to add context to the git log, and I also added a note in the test case to remind ourselves that upstream hasn't fixed this yet. I also removed the internal/encoding/yaml test, as it was now redundant.

[vikstrous]

Great! Thanks!

…

On Fri, Dec 15, 2023, 07:48 Daniel Martí ***@***.***> wrote: Thank you! Imported to Gerrit as https://review.gerrithub.io/c/cue-lang/cue/+/1173689. I hope you don't mind that I wrote a longer commit message to add context to the git log, and I also added a note in the test case to remind ourselves that upstream hasn't fixed this yet. I also removed the internal/encoding/yaml test, as it was now redundant. — Reply to this email directly, view it on GitHub <#2729 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADVY6O7L4Z4IZCNC3VQEIDYJRBKVAVCNFSM6AAAAABANFTQ62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJXHAZTENZZHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>