Skip to content

Add share button when resource sharing is enabled#3

Open
cwperks wants to merge 9 commits intomainfrom
share-button
Open

Add share button when resource sharing is enabled#3
cwperks wants to merge 9 commits intomainfrom
share-button

Conversation

@cwperks
Copy link
Copy Markdown
Owner

@cwperks cwperks commented Mar 29, 2026

Description

Companion PRs:

This PR adds share buttons in dashboards-reporting repo to make sharing easy for report definitions and report instances.

Currently, in order to share it requires plugins.alerting.filter_by_backend_roles to be set to true and has no API to change sharing. When plugins.alerting.filter_by_backend_roles is set to true a report is "shared" with userB if userB shares a backend role with userA, the creator of the report.

Sharing Modal:

Screenshot 2026-03-29 at 1 30 11 PM

Share Button:

Screenshot 2026-03-29 at 1 30 02 PM

Note: this PR adds the sharing modal in this repo initially, but plans would be ultimately to make this re-usable across the project.

Note 2: Currently a user must type out a target username or target role explicitly. There is another plan to make these typeaheads.

Roles would be trivial as those are roles stored within OpenSearch.

Username for internalusers would be quick to support, but full report requires: opensearch-project/security-dashboards-plugin#2285

Issues Resolved

Related to: opensearch-project/security#4500

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <craig5008@gmail.com>
Signed-off-by: Craig Perkins <craig5008@gmail.com>
cwperks added 7 commits March 29, 2026 14:24
Signed-off-by: Craig Perkins <craig5008@gmail.com>
Signed-off-by: Craig Perkins <craig5008@gmail.com>
Signed-off-by: Craig Perkins <craig5008@gmail.com>
Signed-off-by: Craig Perkins <craig5008@gmail.com>
Signed-off-by: Craig Perkins <craig5008@gmail.com>
Signed-off-by: Craig Perkins <craig5008@gmail.com>
Signed-off-by: Craig Perkins <craig5008@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant