Add share button when resource sharing is enabled#3
Open
Conversation
Signed-off-by: Craig Perkins <craig5008@gmail.com>
5 tasks
5 tasks
Signed-off-by: Craig Perkins <craig5008@gmail.com>
Signed-off-by: Craig Perkins <craig5008@gmail.com>
Signed-off-by: Craig Perkins <craig5008@gmail.com>
Signed-off-by: Craig Perkins <craig5008@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion PRs:
This PR adds share buttons in dashboards-reporting repo to make sharing easy for report definitions and report instances.
Currently, in order to share it requires
plugins.alerting.filter_by_backend_rolesto be set to true and has no API to change sharing. Whenplugins.alerting.filter_by_backend_rolesis set to true a report is "shared" with userB if userB shares a backend role with userA, the creator of the report.Sharing Modal:
Share Button:
Note: this PR adds the sharing modal in this repo initially, but plans would be ultimately to make this re-usable across the project.
Note 2: Currently a user must type out a target username or target role explicitly. There is another plan to make these typeaheads.
Roles would be trivial as those are roles stored within OpenSearch.
Username for internalusers would be quick to support, but full report requires: opensearch-project/security-dashboards-plugin#2285
Issues Resolved
Related to: opensearch-project/security#4500
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.