fix: can send FormData with File.#16576
Merged
chrisbreiding merged 3 commits intocypress-io:developfrom May 24, 2021
Merged
Conversation
Contributor
|
Thanks for taking the time to open a PR!
|
Contributor
Author
|
Flaky failures I guess. |
chrisbreiding
requested changes
May 21, 2021
Contributor
chrisbreiding
left a comment
There was a problem hiding this comment.
I think the 2 tests currently failing are legitimate. Looks like something is causing socket-io's hasBinary to infinitely recurse.
Contributor
Author
|
@chrisbreiding I failed to reproduce the |
Contributor
|
I saw the |
chrisbreiding
approved these changes
May 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User facing changelog
As
socket.ioignoresFormDatabody, Cypress driver couldn't sendFormDatawith file. This PR fixes this behavior.Additional details
cy.request()doesn't support it.socker.io.How has the user experience changed?
N/A
PR Tasks