Skip to content

prevent an infinite loop #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fil merged 2 commits into from
Jul 27, 2020
Merged

prevent an infinite loop #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2133c7
prevent an infinite loop
Fil Jul 6, 2020
702ea2c
crash test
Fil Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default function(x, y) {

// Otherwise, double repeatedly to cover.
else {
var z = x1 - x0,
var z = x1 - x0 || 1,
node = this._root,
parent,
i;
Expand Down
5 changes: 5 additions & 0 deletions test/cover-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,8 @@ tape("quadtree.cover(x, y) does not wrap the root node if it is undefined", func
test.equal(q.copy().cover(-3, -3).root(), undefined);
test.end();
});

tape("quadtree.cover() does not crash on huge values", function(test) {
d3_quadtree.quadtree([[1e23, 0]]);
test.end();
});