No trailing spaces after params with no description#106
Open
S-Mann wants to merge 1 commit intodadadel:masterfrom
Open
No trailing spaces after params with no description#106S-Mann wants to merge 1 commit intodadadel:masterfrom
S-Mann wants to merge 1 commit intodadadel:masterfrom
Conversation
a-t-0
suggested changes
May 14, 2022
There was a problem hiding this comment.
Thank you for your contribution! I often run pre-commit twice when after running pyment to realise flake8 compliance. I appreciate how your work improves flake8 compliance. Would you be willing to write a test that shows the change you made?
Note I have no affiliations with pyment, I just like the software.
| if len(self.docs['out']['params']): | ||
| for p in self.docs['out']['params']: | ||
| raw += self.docs['out']['spaces'] + self.dst.get_key('param', 'out') + ' ' + p[0] + sep + with_space(p[1]).strip() | ||
| description = sep + with_space(p[1]).strip() if p[1] else '' |
There was a problem hiding this comment.
It is not quite clear to me what this line does, would you, if you consider it appropriate, consider including a comment on what it does?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw #43 and I can update the code to consider some flag as per your suggestion