Conversation
|
@DanceaVlad POST DELETE - same, some deletion scenarios need better error handling. |
b9759db to
2e4cf61
Compare
GeoffreyKarnbach
left a comment
There was a problem hiding this comment.
Great work! Please just change the few minor requests!
scripts/README.md
Outdated
| # Translation Management Scripts | ||
|
|
||
| ## Overview | ||
|
|
||
| This directory contains scripts for managing backend translations in the DAMAP system. | ||
|
|
There was a problem hiding this comment.
Talked with Valentin, maybe rather include this README content in the PR description, as we do not strictly need it here.
src/main/java/org/damap/base/rest/translation/service/TranslationService.java
Show resolved
Hide resolved
src/main/resources/org/damap/base/db/changeLog-5.x/changeLog-5.0.0_1.yaml
Outdated
Show resolved
Hide resolved
src/main/resources/org/damap/base/db/changeLog-5.x/changeLog-5.0.0_2.yaml
Show resolved
Hide resolved
|
Also rebase the branch please, there were no conflicts for me when I did it locally! |
src/main/java/org/damap/base/rest/translation/service/TranslationService.java
Show resolved
Hide resolved
2e4cf61 to
cb0f142
Compare
Description
Feature
What does this PR do?
Implements a way for admins to create/delete/modify languages, along with their translation keys and values
Code review focus
Dependencies
This PR requires a frontend UI implementation.
Checks
closes GH-445