Skip to content

feature: translation management#452

Draft
DanceaVlad wants to merge 3 commits intonextfrom
vd/445-translation-management
Draft

feature: translation management#452
DanceaVlad wants to merge 3 commits intonextfrom
vd/445-translation-management

Conversation

@DanceaVlad
Copy link
Member

Description

Feature

What does this PR do?

Implements a way for admins to create/delete/modify languages, along with their translation keys and values

Code review focus

  • Service error handling and permission, such as not allowing the english language to be deleted, not allowing the default translations to be modified...
  • Liquibase changelog id and versions

Dependencies

This PR requires a frontend UI implementation.

Checks

  • remove the Python script for generating the Liquibase changelog and its associated README.md and JSON file

closes GH-445

@lpandath
Copy link
Contributor

lpandath commented Jan 9, 2026

@DanceaVlad
while integrating the translation management frontend with your backend, I encountered a couple of issues:

POST ${this.backendUrl}translations/language/${language} - when trying to create a language that already exists, it throws an EntityExistsException. It would be better if this endpoint was idempotent (return success if the language already exists) or returned a clearer error message.

DELETE - same, some deletion scenarios need better error handling.
to be able to work during development, I added a tmp mock service TranslationMockService in the frontend that tracks languages when backend operations fail, until this is resolved.

@DanceaVlad DanceaVlad force-pushed the vd/445-translation-management branch 2 times, most recently from b9759db to 2e4cf61 Compare January 20, 2026 14:14
Copy link
Contributor

@GeoffreyKarnbach GeoffreyKarnbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Please just change the few minor requests!

Comment on lines +1 to +6
# Translation Management Scripts

## Overview

This directory contains scripts for managing backend translations in the DAMAP system.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked with Valentin, maybe rather include this README content in the PR description, as we do not strictly need it here.

@GeoffreyKarnbach
Copy link
Contributor

Also rebase the branch please, there were no conflicts for me when I did it locally!

@DanceaVlad DanceaVlad force-pushed the vd/445-translation-management branch from 2e4cf61 to cb0f142 Compare March 11, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add translation management

3 participants