Helm(fix): update outdated custom domain value in damap ingress & fix custom build refs#474
Merged
SotosTsepe merged 2 commits intonextfrom Mar 10, 2026
Merged
Helm(fix): update outdated custom domain value in damap ingress & fix custom build refs#474SotosTsepe merged 2 commits intonextfrom
SotosTsepe merged 2 commits intonextfrom
Conversation
SotosTsepe
force-pushed
the
st/patch-helm-chart
branch
from
fe38f43 to
4d7fa25
Compare
ValentinFutterer
force-pushed
the
st/patch-helm-chart
branch
from
4d7fa25 to
b877fb1
Compare
SotosTsepe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix renames the outdated
custom_domainvalue tocustomDomain.This affects OpenShift deployments using a custom domain; the chart rendered the default OpenShift
Routeresources instead of the expectedIngressresources using the OpenShiftingressClass(fetched from thevalues.yaml).The custom build was also fixed, referencing the correct image registry from OpenShift.
Note: If running the chart with kustomize (as in our case), remember to specify the namespace explicitly in the charts section ( {{ .Release.namespace }} may not be correctly populated in the custom build section)