Multitenancy: Replace SecurityAugmentor by ContainerRequestFilter to cache users in DB, while being compatible with multitenancy#478
Open
GeoffreyKarnbach wants to merge 2 commits intonextfrom
Conversation
…cache users in DB, while being compatible with multitenancy
Member
|
Tested on OpenShift, unfortunately doesn't work: I still had to guard the null tenantId (before login) to make it work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactoring / Bugfix
What does this PR do?
This PR resolves a compatibility issue between the OIDC user synchronization and multitenancy.
DamapSecurityAugmentor. Because security augmentors run extremely early in the Quarkus reactive pipeline, it attempted to execute database operations before the multitenancy context was fully established, causing tenant routing errors.UserSyncFilter(implementingContainerRequestFilter). This ensures the user sync executes after authentication and tenant resolution are complete, allowing it to safely write to the correct tenant's database.(Note: This solution was tested locally with the multitenancy setup active and successfully passed, routing and saving users to the correct tenant databases.)