Merged
Conversation
mimvoid
changed the title
mimvoid
changed the title
mimvoid
force-pushed
the
add-contrast-checking
branch
from
889331c to
f93f5eb
Compare
danihek
approved these changes
Jul 20, 2025
Owner
danihek
left a comment
danihek
left a comment
There was a problem hiding this comment.
Thanks for this, I tried it and everything looks good to me. Good job! :)
Contributor
Author
Hooray, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds contrast checking with contrast ratio calculations based on wallust's implementation and WCAG's Technique G18, which closes #33.
It doesn't make much of a difference for some images, but certainly helps with low contrast ones.
Also adds the
--check-contrastflag to the documentation.