Add need bonus for CI blocking merge on approved PRs#25
Conversation
An approved PR with failing CI and no unresolved threads was scoring need=0, even though the next action clearly requires attention (fix CI to unblock merge). Add +1.5 need points for this case. Updated in: scoring logic, value/action tooltips, scoring tables in the per-repo template, cross-repo page, and weightings README. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adjusts the dashboard’s “Need” scoring so PRs that are effectively ready-to-merge but blocked by failing CI (despite approval and no unresolved threads) get surfaced as actionable work, aligning score signals with the “next action” guidance.
Changes:
- Add a +1.5 “Need” bonus when CI is failing and the PR is approved with no unresolved threads.
- Surface the new scoring signal in “Need” breakdown tooltips and the unified “Action” tooltip contributors.
- Update the scoring explainer tables and weighting documentation to include the new signal.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/weightings/README.md | Documents the new +1.5 “CI blocking merge” Need signal. |
| scripts/Get-PrTriageData.ps1 | Implements the new Need bonus and adds corresponding tooltip/action contributor text. |
| scripts/ConvertTo-ReportHtml.ps1 | Updates the per-repo report scoring explainer HTML table. |
| docs/all/actionable.html | Updates the cross-repo scoring explainer HTML table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Factor the repeated condition into a shared $ciBlockingMerge boolean and add -not $hasNeedsAuthorAction so the bonus/tooltips don't fire when author-action is still required. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Also require mergeable != CONFLICTING so the bonus doesn't fire when a merge conflict is the actual blocker, not CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The scoring condition now also excludes needs-author-action and merge conflicts, so simplify the description to 'otherwise merge-ready' in the scoring tables and weight docs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
An approved PR with failing CI and no unresolved review threads was scoring need=0, even though the next action clearly says "@author: fix CI failures." The PR is ready to merge except for CI — that needs attention.
Fix: Add +1.5 need points when
CI == FAILUREand the PR has approval and no unresolved threads. This matches the existing +1.5 for "no approval yet" — both are blockers that need someone to act.Example: PR dotnet/runtime#124628 had approval, no open threads, but failing CI. It showed need=0 and action=0 despite "fix CI failures" being the next action.
Changes:
Get-PrTriageData.ps1: scoring logic, value tooltip, action tooltipConvertTo-ReportHtml.ps1: per-repo scoring table templatedocs/all/actionable.html: cross-repo scoring tablescripts/weightings/README.md: weight documentation