AppKit Improvements (Getting TextEdit to compile and Run)#29
AppKit Improvements (Getting TextEdit to compile and Run)#29CuriousTommy merged 13 commits intodarlinghq:masterfrom
Conversation
CKegel
changed the title
|
I'm working on finalizing this PR, and I plan to do the following before I'd consider it ready to merge(after review):
After this PR is eventually merged, I'd like to create an issue where I can track progress on the rest of my AppKit improvements for TextEdit as, while this PR makes great strides, it doesn't even come close to making TextEdit run perfectly. Let me know what ya'll think and I'll be back to implement it after my final exams have wrapped up next week! |
CKegel
force-pushed
the
TextEdit_patches
branch
16 times, most recently
from
bc723e1 to
cdd4de1
Compare
facekapow
left a comment
facekapow
left a comment
There was a problem hiding this comment.
LGTM except for one minor note
CKegel
force-pushed
the
TextEdit_patches
branch
4 times, most recently
from
3808f90 to
332d6e6
Compare
Fix issue where a layout manager's NSTextStorage could be `nil` at initialization but later set by introducing the `_setTextStorage:` method to NSTextView. Add stubs a for missing properties in NSTextView. Refactor `firstTextView` to properly find and return the first text view, or `nil` if there are no text views. Use 64-bit ready types where applicable. Relocate unrelated code from _setTextStorage
Adds code in `initWithData` to infer document format for RTF, HTML, and plaintext documents. Additionally refactors NSAttributedString to use the correct attribute types as described in Apple's documentation.
Add stubs for content size, frame size, and magnification size, and add basic implementations where feasible.
Implement NSTextTab handling based on the GNUStep implementation, with formatting and other adjustments.
CKegel
force-pushed
the
TextEdit_patches
branch
from
c29895d to
d6c5c1c
Compare
AppKit/NSDocumentController.m
Outdated
|
|
||
| return (result == nil) ? [_NSUnsupportedDocument class] : NSClassFromString(result); | ||
| return (result == nil) ? [_NSUnsupportedDocument class] | ||
| : NSClassFromString(result); |
There was a problem hiding this comment.
If there is no such class (with this name), should this:
- return
nil - return
_NSUnsupportedDocument - crash (throw an exception)?
|
@bugaevc I don't remember if we talk about this before, but I'm thinking of merging this as is, unless you have any objections. |
|
Please do. Whatever remaining objections/corrections I might/would have had would be better dealt with after the fact, compared to keeping this stalled indefinitely. |
|
Thank you for your contribution @CKegel! |
4 participants
Adds stubs and implements missing functionality as required for Apple TextEdit to compile and run.
Also note the following related PRs:
✅ CoreFoundation
✅ LaunchServices
✅ AppleEvents Stubs
✅ TextEdit CMake
Fixes Issue 383
